Relax validation of SCATTER/GATHER memory ops to spec, Fixes #193 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 75.95% 75.95% -0.01%
==========================================
Files 65 65
Lines 20633 20694 +61
==========================================
+ Hits 15672 15718 +46
- Misses 4879 4894 +15
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merge branch 'master' into fix_scatter_gather_mem_op
|
@mmcloughlin Happy to see recent activity on Avo. I'd love to get some PRs merged so I can get off my fork. This one is a pretty straightforward fix, would be great to land it soon. Not sure what's up with the pr/automerge fail above, looks like maybe I don't have some permission? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #193 and discussion here: #199 (comment)